Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in stretching matrix in layered model #325

Open
mpudig opened this issue Sep 29, 2023 · 0 comments
Open

Mistake in stretching matrix in layered model #325

mpudig opened this issue Sep 29, 2023 · 0 comments

Comments

@mpudig
Copy link

mpudig commented Sep 29, 2023

Hi,

We (in fact, @Empyreal092) noticed a possible mistake in how the reduced gravities are defined in layered_model (https://github.com/pyqg/pyqg/blob/master/pyqg/layered_model.py#L176).

It is our understanding that in the multi-layer QG equations, one should divide by a reference density in the reduced gravities (see Vallis, 2017 p.186), rather than by the density of each layer as is currently done in layered_model (as well as in its pyqg documentation).

Could anyone who was part of model development (@rabernat, @MFJansen, @cesar-rocha, @francispoulin perhaps) comment on whether this is in fact a typo, or if there was a reason behind this choice for the reduced gravities? I'd be happy to push through the changes necessary if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant