tavestart

[cesar-rocha]

tavestart is supposed to be the time at which the model start computing averages for the diagnostics, but it is never used in model.py. Here's what _calc_diagnostic does:

if (self.t>=self.dt) and (self.tc%self.taveints==0):
       self._increment_diagnostics()

(...)

is tavestart used elsewhere?

(I think we're missing a self.t>=self.tavestart above).

[rabernat]

I wonder how far back this goes. Most of this logic can be traced back to Malte's original code.

Anyway, obviously a bug, and easily fixed. Are you going to do it?

On Oct 5, 2015, at 12:59 AM, Cesar B Rocha notifications@github.com wrote:

tavestart is supposed to be the time at which the model start computing averages for the diagnostics, but it is never used in model.py. Here's what _calc_diagnostic does:

if (self.t>=self.dt) and (self.tc%self.taveints==0):
self._increment_diagnostics()

(...)
is tavestart used elsewhere?

(I think we're missing a self.t>=self.tavestart above).

—
Reply to this email directly or view it on GitHub.

[MFJansen]

I believe it happened on March 28:
26f9111#diff-c6c9f6600ccc812b2e7038316e6eff8e

I assume this was an accidental edit?

[rabernat]

You're busted @crocha700! 😝

[cesar-rocha]

Thanks for digging that out @MFJansen. This was likely an accidental edit. My bad: unfortunately that commit is very non specific – too many changes in a single commit... I just submitted a PR fixing it.

I also fixed in my brach multi_layer which I'm going to merge into develop later today.