Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vertical and horizaontal symbol #2979

Closed
wants to merge 4 commits into from

Conversation

kevinsmia1939
Copy link
Contributor

Detail the reasoning behind the code change. If there is an associated issue that this PR will resolve add

This PR add vertical and horizontal symbol.

Fixes #

Other Tasks

Bump Dependency Versions

Files that need updates

Confirm the following files have been either updated or there has been a determination that no update is needed.

  • README.md
  • setup.py
  • tox.ini
  • .github/workflows/main.yml and associated requirements.txt and conda environemt.yml files
  • pyproject.toml
  • binder/requirements.txt
Pre-Release Checklist

Pre Release Checklist

  • Update version info in __init__.py
  • Update CHANGELOG primarily using contents from automated changelog generation in GitHub release page
  • Have git tag in the format of pyqtgraph-
Post-Release Checklist

Steps To Complete

  • Append .dev0 to __version__ in __init__.py
  • Announce on mail list
  • Announce on Twitter

@pijyoi
Copy link
Contributor

pijyoi commented Apr 10, 2024

I see that you have used the same mnemonics as matplotlib
(https://matplotlib.org/stable/api/markers_api.html)

Could you add your new symbols to:
https://github.com/pyqtgraph/pyqtgraph/blob/master/pyqtgraph/examples/Symbols.py

And also update _symbol_pg_to_mpl in:
https://github.com/pyqtgraph/pyqtgraph/blob/master/pyqtgraph/exporters/Matplotlib.py#L32-L50

@j9ac9k
Copy link
Member

j9ac9k commented Apr 18, 2024

Superseded by #2985

Thanks for the PR @kevinsmia1939 !

@j9ac9k j9ac9k closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants