Allow users to specify FillRule for FillBetweenItem, undo regressionfrom #2971 #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2024
j9ac9k
force-pushed
the
fix-fillbetween-regression
branch
2 times, most recently
from
d24a434
to
02ea491
Compare
j9ac9k
changed the title
j9ac9k
force-pushed
the
fix-fillbetween-regression
branch
4 times, most recently
from
bfcde03
to
39f9cdc
Compare
Users can now specify QtCore.Qt.FillRule.WindingFill as a fill rule to FillBetweenItem, as opposed to the default FillRule.OddEvenFill. Add some docstrings and type annotations for FillBetweenItem Undo a regression introduced in 0.13.5 which attempted to fill in voided enclosed areas, which the WindingFill rule can usually address.
j9ac9k
force-pushed
the
fix-fillbetween-regression
branch
from
39f9cdc
to
a933120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1698