Fixup 3007 #3008
Merged
Fixup 3007 #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9ac9k
force-pushed
the
fix-mistake-in-3007
branch
6 times, most recently
from
76267ba
to
1963899
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
j9ac9k
force-pushed
the
fix-mistake-in-3007
branch
3 times, most recently
from
8552c6b
to
d01055e
Compare
pijyoi
reviewed
Apr 28, 2024
In some rare occasions in CI, try_fastpath_argb would trigger a segfault Since this function pre-dates functions_qimage.try_make_qimage, we can retire this function with minimal impact to end users. Furthermore, uncomment out the tests that were commented out in pyqtgraph#3007
j9ac9k
force-pushed
the
fix-mistake-in-3007
branch
from
d01055e
to
f304731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add commented out tests in #3007