Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue # 366 #626

Merged
merged 1 commit into from Feb 5, 2018
Merged

Fix issue # 366 #626

merged 1 commit into from Feb 5, 2018

Conversation

feketeimre
Copy link
Contributor

Set the right texture for rendering, otherwise a previously set texture is overwritten.

Set the right texture for rendering, otherwise a previously set texture is overwritten.
@codecov-io
Copy link

Codecov Report

Merging #626 into develop will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #626      +/-   ##
===========================================
- Coverage    36.83%   36.82%   -0.02%     
===========================================
  Files          198      198              
  Lines        27088    27090       +2     
  Branches      4458     4458              
===========================================
- Hits          9978     9975       -3     
- Misses       16252    16256       +4     
- Partials       858      859       +1
Impacted Files Coverage Δ
pyqtgraph/opengl/items/GLScatterPlotItem.py 14.63% <0%> (-0.19%) ⬇️
pyqtgraph/opengl/GLViewWidget.py 19.73% <0%> (-0.07%) ⬇️
pyqtgraph/multiprocess/remoteproxy.py 57.14% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e65ab3f...8d9cb79. Read the comment docs.

@campagnola
Copy link
Member

I wasn't able to reproduce the problem (which is not surprising; opengl drivers have widely inconsistent implementations). However your explanation makes perfect sense, so: merge!
Thanks for all the detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants