Fix/unittest fail due to use of private method #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent versions of composer, the accessibility to the addPlugin method of the PluginManager was changed from public to private. This change marks the tests as skipped if that is the case.
Most of this new test duplicates the 'test_it_receives_event' method. However, this test does not rely on the internals of composer.
|
Awesome! Thank you! |
pyrech
added a commit
that referenced
this pull request
Feb 23, 2016
…private-method Fix/unittest fail due to use of private method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked the failing test as skipped when a recent version of composer is used in the test environment.
Created a new test method to test the plugin code without relying on the internals of composer.