Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#65 Drop support of old PHP versions #66

Merged
merged 4 commits into from
Oct 17, 2019

Conversation

laurent35240
Copy link
Contributor

No description provided.

Copy link
Owner

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂 I would like to keep builds for lowest dependencies to ensure our minimum requirements are ok. I suggest the following:

        - php: 7.1
          env: deps=low coverage=true
        - php: 7.2
          env: check_cs=true
        - php: 7.3
          env: deps=high coverage=true

@laurent35240
Copy link
Contributor Author

Sure, I added deps=low for the build with PHP 7.1
I did not add deps=high since it is the default value
I put only one coverage=true because I do not see the point of calculating code coverage twice.

BTW I noticed that the Github Access Token became invalid on Scrutinizer
Code Quality Summary - pyrech composer-changelogs - Measure and Improve Code Quality continuously with Scrutinizer

.travis.yml Outdated
- php: 7.1
env: deps=low check_cs=true coverage=true
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not run the check_cs with the lowest dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I changed it.
For curiosity, any particular reason for not running code style check with lowest dependencies?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I probably prefer to have the latest php-cs-fixer rules 🙂

@pyrech
Copy link
Owner

pyrech commented Oct 15, 2019

I just asked a renew of the Scrutinizer token... I think, not sure it worked. I wonder if I should not drop Scrutinizer completly as it's not really useful actually.
Anyway, I just left one comment, and once fixed, I will merge this PR and release a new minor version \o/

@laurent35240
Copy link
Contributor Author

Maybe we can move from Scrutinizer to coveralls if Scrutinizer was just used for code coverage

@studioromeo studioromeo mentioned this pull request Oct 16, 2019
@pyrech
Copy link
Owner

pyrech commented Oct 17, 2019

Awesome, thank you @laurent35240

@pyrech pyrech merged commit 12f6d47 into pyrech:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants