Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting with the Make Pattern tool will work with some patterns but not others #1480

Closed
geistwolke opened this issue Feb 9, 2022 · 14 comments
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Prioritize The issue is planned to be resolved in the next version Tools Issues related to pyRevit commands [subsystem]

Comments

@geistwolke
Copy link

I have some patterns that were lost over the years and I am trying to get back out of Revit. any I am trying to get them back into Revit to make sure they work.

SRP will work as a Drafting , But 3-Hour will not work. Whenever I try to pull 3-Hour it will say there is not a DRAFTING pattern. It will read: ""No "Drafting" type patterns found.""

WORKS

; Written by "Make Pattern" tool for pyRevit
; http://eirannejad.github.io/pyRevit/
;-Date : 2022-02-08
;-Time : 16:04:29
;-pyRevit Version : 4.8.8
;---------------------------------------------------------------------
;%UNITS=INCH
*SRP,exported by pyRevit
;%TYPE=DRAFTING
89.9999999999999000, 0.0, 0.0, 1.0168350000000000, 0.2187500000000000, 1.0168362500000000, -0.0
89.9999999999999000, 0.0009765750000000, 0.0, 1.0168350000000000, 0.2187500000000000, 1.0168362500000000, -0.0
89.9999999999999000, 0.0019531250000004, 0.0, 1.0168350000000000, 0.2187500000000000, 1.0168362500000000, -0.0
89.9999999999999000, 0.0029297000000004, 0.0, 1.0168350000000000, 0.2187500000000000, 1.0168362500000000, -0.0
89.9999999999999000, 0.0039062499999996, 0.0, 1.0168350000000000, 0.2187500000000000, 1.0168362500000000, -0.0
89.9999999999999000, 0.0048828249999996, 0.0, 1.0168350000000000, 0.2187500000000000, 1.0168362500000000, -0.0

WILL NOT WORK

; Written by "Make Pattern" tool for pyRevit
; http://eirannejad.github.io/pyRevit/
;-Date : 2022-02-09
;-Time : 12:10:36
;-pyRevit Version : 4.8.8
;---------------------------------------------------------------------
;%UNITS=INCH
*3-HOUR RATED PARTITION,exported by pyRevit
;%TYPE=DRAFTING
89.9999999999999000, 0.0, 0.0, 0.0, 0.7000000000000000,
89.9999999999999000, 0.0024999999999996, 0.0, 0.0, 0.7000000000000000,
89.9999999999999000, 0.0050000000000004, 0.0, 0.0, 0.7000000000000000,
89.9999999999999000, 0.0075000000000000, 0.0, 0.0, 0.7000000000000000,
89.9999999999999000, 0.0099999999999996, 0.0, 0.0, 0.7000000000000000,
89.9999999999999000, 0.0125000000000004, 0.0, 0.0, 0.7000000000000000,
srp
3hour

@eirannejad
Copy link
Collaborator

Seems like the pattern file has extra commas at the end of the lines. Try this:

; Written by "Make Pattern" tool for pyRevit
; http://eirannejad.github.io/pyRevit/
;-Date : 2022-02-09
;-Time : 12:10:36
;-pyRevit Version : 4.8.8
;---------------------------------------------------------------------
;%UNITS=INCH
*3-HOUR RATED PARTITION,exported by pyRevit
;%TYPE=DRAFTING
89.9999999999999000, 0.0, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0024999999999996, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0050000000000004, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0075000000000000, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0099999999999996, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0125000000000004, 0.0, 0.0, 0.7000000000000000

@eirannejad eirannejad added Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Prioritize The issue is planned to be resolved in the next version Tools Issues related to pyRevit commands [subsystem] labels Feb 9, 2022
@eirannejad
Copy link
Collaborator

eirannejad commented Feb 9, 2022

⚠️ Note to Developer

Example of a pattern that does not work. A pattern imported into Revit as:

; Written by "Make Pattern" tool for pyRevit
; http://eirannejad.github.io/pyRevit/
;-Date : 2022-02-09
;-Time : 12:10:36
;-pyRevit Version : 4.8.8
;---------------------------------------------------------------------
;%UNITS=INCH
*3-HOUR RATED PARTITION,exported by pyRevit
;%TYPE=DRAFTING
89.9999999999999000, 0.0, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0024999999999996, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0050000000000004, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0075000000000000, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0099999999999996, 0.0, 0.0, 0.7000000000000000
89.9999999999999000, 0.0125000000000004, 0.0, 0.0, 0.7000000000000000

will be exported from pyRevit as below with extra commas:

; Written by "Make Pattern" tool for pyRevit
; http://eirannejad.github.io/pyRevit/
;-Date : 2022-02-09
;-Time : 12:10:36
;-pyRevit Version : 4.8.8
;---------------------------------------------------------------------
;%UNITS=INCH
*3-HOUR RATED PARTITION,exported by pyRevit
;%TYPE=DRAFTING
89.9999999999999000, 0.0, 0.0, 0.0, 0.7000000000000000, 
89.9999999999999000, 0.0024999999999996, 0.0, 0.0, 0.7000000000000000, 
89.9999999999999000, 0.0050000000000004, 0.0, 0.0, 0.7000000000000000, 
89.9999999999999000, 0.0075000000000000, 0.0, 0.0, 0.7000000000000000, 
89.9999999999999000, 0.0099999999999996, 0.0, 0.0, 0.7000000000000000, 
89.9999999999999000, 0.0125000000000004, 0.0, 0.0, 0.7000000000000000, 

eirannejad added a commit that referenced this issue Feb 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2022

📦 New work-in-progress (wip) builds are available for 4.8.11.22040+1952-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22041+1802-wip

@geistwolke
Copy link
Author

thanks!

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22048+0206-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22081+0059-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22103+0000-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22135+0143-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22135+0146-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22135+0146-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22136+0257-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.11.22151+0307-wip

@github-actions
Copy link
Contributor

📦 New public release are available for 4.8.11.22151+0454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug that stops user from using the tool or a major portion of pyRevit functionality [class] Prioritize The issue is planned to be resolved in the next version Tools Issues related to pyRevit commands [subsystem]
Projects
None yet
Development

No branches or pull requests

2 participants