Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1704 #1765

Merged
merged 2 commits into from
May 2, 2023
Merged

#1704 #1765

merged 2 commits into from
May 2, 2023

Conversation

nodatasheet
Copy link
Contributor

This PR is to address the issue #1704

Basically I replaced w and r by the wb and rb to specify binary modes during open command.
Did it everywhere where I could find usage of pickle module:

  • memo buttons
  • sync view smart button

Tested in IPY277 and IPY340 on Revit 2023 | Version: 23.1.10.4

@jmcouffin jmcouffin requested a review from thumDer March 21, 2023 10:01
@jmcouffin jmcouffin removed the request for review from thumDer May 2, 2023 07:36
@jmcouffin jmcouffin added the Tools Issues related to pyRevit commands [subsystem] label May 2, 2023
@jmcouffin jmcouffin linked an issue May 2, 2023 that may be closed by this pull request
IPY340 MWrite.pushbutton pickle module TypeError #1704
Closed
@jmcouffin jmcouffin merged commit b42c438 into pyrevitlabs:develop May 2, 2023
@jmcouffin jmcouffin mentioned this pull request May 2, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23122+0740-wip

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

📦 New work-in-progress (wip) builds are available for 4.8.13.23126+1635-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23131+1009-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23137+0756-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23137+0809-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23139+0632-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0857-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0943-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+0957-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23144+1030-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23161+1332-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0849-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0858-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0910-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+0908-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1046-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1150-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23163+1153-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23164+0946-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23165+1014-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23166+0843-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+0833-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1018-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23170+1041-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23177+1038-wip

@github-actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 4.8.13.23181+1652-wip

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

📦 New public release are available for 4.8.13.23182+2215

@nodatasheet nodatasheet deleted the 1704 branch September 8, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Tools Issues related to pyRevit commands [subsystem]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPY340 MWrite.pushbutton pickle module TypeError
2 participants
@nodatasheet @jmcouffin