Skip to content

Commit

Permalink
Fix crash in Gregminster events (German version)
Browse files Browse the repository at this point in the history
The German translation has a path through the meeting with Lepant that traps the player into a crash.  If you choose to review the stats of the offered recruits, the option that retruns you to the actual selection dialogue is broken due to the text having too many line breaks.  The fix reformats the text, removing the line breaks.
  • Loading branch information
pyriell committed Jan 4, 2019
1 parent f563559 commit 5ccbd42
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 0 deletions.
Binary file added patch/European-G/gregminstercrash.ppf
Binary file not shown.
25 changes: 25 additions & 0 deletions patch/European-G/src/gregminstercrash.asm
@@ -0,0 +1,25 @@
; Suikoden II Gregminster Recruiting Crash
; Written by Pyriel
;
; Fixes an issue with the translation that causes a crash during the meeting with Lepant in Gregminster.
; Two of the three options were extended to a second line in the German text, pushing the choices beyond
; the size allowed by the game. When the last option is selected, it returns an option number
; not allowed by the script, resulting in a crash when no scripting is found to handle the player's
; choice.
;
; Changing the last newline character in the strings to a space fixes the issue, and the text
; has plenty of space left before it would overflow the right margin of the box.
;

.psx
.openfile VF04.BIN, 0x8015DC50
.align 4

.org 0x80168115
.byte 0x10

.org 0x8016813D
.byte 0x10


.close
7 changes: 7 additions & 0 deletions patcher.lua
Expand Up @@ -2841,6 +2841,13 @@ PackageInfo = {
Search = {{ Value="GOZZ", Replace="GOZU", Case="false", VarQual="gozz" }},
Excludes = { "Gozz Rune Renamed Minotaur Rune" }
},

{
Name="Gregminster Recruiting Crash Fix",
Description="Fixes a crash that occurs when meeting Lepant, if you take a moment to review the recruits he offers.",
Active = 1, Toggle = 0,
Files = {{ Type = "PPF", PatchFileName = "gregminstercrash.ppf", GameFileName = "VF04.BIN" }}
},

{
Name="Inns Fix",
Expand Down
3 changes: 3 additions & 0 deletions readme.html
Expand Up @@ -51,6 +51,9 @@ <h4>Forgiver Sign Fix</h4>
<h4>Gozz Rune Name Fixes</h4>
Will change the name of the Gozz Rune to either "Gozu" (more appropriate if you are familiar with Japanese myths) or "Minotaur" (for Westerners).

<h4>Gregminster Crash Fix (Germany Only)</h4>
When meeting Lepant, and reviewing the recruits he offers, the German version can crash due to the text containing more line-breaks than the dialogue box allows for player options. The fix removes line breaks from two dialogue strings that are both roughly, "review notes on <person>."

<h4>GS1 Load - Names Fix</h4>
Corrects the re-encoding of names so that your hero from Suikoden will have the name you gave him. It also fixes the import of the Castle name from the original game, but that can only be seen in one Old Book.

Expand Down
4 changes: 4 additions & 0 deletions readme.md
Expand Up @@ -52,6 +52,10 @@ Repairs a cosmetic issue where Forgiver Sign would appear to cause strangely mas
### Gozz Rune Name Fixes
Will change the name of the Gozz Rune to either "Gozu" (more appropriate if you are familiar with Japanese myths) or "Minotaur" (for Westerners).

### Gregminster Crash Fix (Germany Only)
When meeting Lepant, and reviewing the recruits he offers, the German version can crash due to the text containing more line-breaks than the dialogue box allows for player options. The fix removes line breaks from two dialogue strings that are both roughly, "review notes on <person>."


### GS1 Load - Names Fix
Corrects the re-encoding of names so that your hero from Suikoden will have the name you gave him. It also fixes the import of the Castle name from the original game, but that can only be seen in one Old Book.

Expand Down

0 comments on commit 5ccbd42

Please sign in to comment.