Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface tweaks #32

Open
3 of 5 tasks
null-a opened this issue Oct 11, 2019 · 0 comments
Open
3 of 5 tasks

Interface tweaks #32

null-a opened this issue Oct 11, 2019 · 0 comments
Labels
discussion Requires broader discussion
Milestone

Comments

@null-a
Copy link
Collaborator

null-a commented Oct 11, 2019

We might be able to give some things better names:

  • iter parameter of nuts to num_samples
  • fit.fitted to fit.predict? (both exist in brms, and IIRC fitted in brmp implements aspects of each of these.) Alternatively, we could move away from a single mega-method towards separate methods for each kind of prediction? (i.e. We could have separate methods, one for each valid what argument that can be passed to fitted.)
  • defm to brm? (defm is short for "define model", but it wasn't a well considered choice. brm is used in brms for something similar but not quite the same -- it both defines and fits a model -- which might cause confusion.)
  • DefmResult and GenerateResult might seem a bit odd when they appear in documentation.
  • Drop the nuts,svi,prior methods on DefmResults? (i.e. Remove support for doing defm(...).prior().) These are a middle ground between the convenience of def(...).fit()and the flexibility of e.g. defm(...).generate(...).nuts(...), but it's not clear they add much. Also, they are currently hard-coded to use only the default back end.
@null-a null-a added this to the v0.0.1 milestone Oct 11, 2019
@null-a null-a added the discussion Requires broader discussion label Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires broader discussion
Projects
None yet
Development

No branches or pull requests

1 participant