Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move methods on to Fit class. #51

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Move methods on to Fit class. #51

merged 2 commits into from
Oct 17, 2019

Conversation

null-a
Copy link
Collaborator

@null-a null-a commented Oct 16, 2019

This moves marginals, fitted etc. from top-level methods to methods on the Fit class. (Closes #50.)

I'm personally happy with either approach, but I'm guessing the change is worth making since the result is arguably more idiomatic. Agreed?

neerajprad
neerajprad reviewed Oct 17, 2019
View reviewed changes
brmp/fit.py Outdated Show resolved Hide resolved
neerajprad
neerajprad approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@neerajprad neerajprad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like this because users won't need to do extra imports and can simply look up all the methods available on the Fit class. Feel free to merge at your convenience.

@null-a
Copy link
Collaborator Author

null-a commented Oct 17, 2019

Great, thanks @neerajprad.

@null-a null-a merged commit f1ee14a into master Oct 17, 2019
@null-a null-a deleted the fit_class branch October 17, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neerajprad neerajprad neerajprad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move marginals, get_scalar_param etc. to methods on Fit
2 participants
@null-a @neerajprad