-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor according to v2 design doc #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eb8680 I'm ready to merge this any time.
|
BTW please do a "squash merge" to hide my missteps 😉 |
eb8680
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much cleaner! I'm happy with the state of things now so I think it makes sense to merge this and address remaining things in self-contained followup issues/PRs.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16
See design doc for details.
Summary
FunsorMeta.__call__()
by replacingeffectful
with a single settable function, defined byfunsor.interpreter
. The function is accessed byinterpreter.interpret()
andfunsor.eval()
is renamed tointerpreter.reinterpret()
.eager
,lazy
(for lazy ops but eager substitution), andreflect
(completely lazy).Tasks
contract_engine
,tree_engine
)update funsor.distributionsupdate test/test_distributions.py