Add support for most remaining atomic distributions #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb8680
force-pushed
the
add-all-torch-distributions
branch
from
b28f92d
to
55fd790
Compare
fritzo
approved these changes
Nov 11, 2020
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #386.
Blocked by #389.This PR adds Funsor wrappers for most of the remaining atomic distributions in
torch.distributionsandnumpyro.distributions, and test cases intest_distribution_generic.py. I have also added a small helperxfail_if_not_foundto make writing tests for multiple backends a bit easier.Tested: