Require sample_shape passed as keyword argument to AutoGuides #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
approved these changes
Oct 7, 2023
|
Hi @tare, could you help removing PriorModelGen and its corresponding usages in that file? It's causing CI to fail. |
|
Sure thing! Yep, it looks like jaxns got a new release recently; this was the commit in which |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fehiepsi proposed in #1644 that the signatures of
.sample_posterior()of different implementations ofAutoGuideare made consistent in two steps: 1) enforce thatsample_shapeis passed as a keyword argument in the next release and 2) introduce*argsand**kwargsafter the next release.This PR addresses the first step by putting
*beforesample_shapein the signatures of.sample_posterior()that do not have*argsand**kwargsyet.Probably these changes do not require additional unit tests.