fix init_params bug in hmcgibbs #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
approved these changes
Nov 9, 2023
numpyro/infer/hmc_gibbs.py
Outdated
| for name, site in self._prototype_trace.items(): | ||
| if init_params and name in init_params: | ||
| gibbs_sites[name] = init_params[name] | ||
| init_params.pop(name) |
There was a problem hiding this comment.
I think you can combine those lines into ... = init_params.pop(name).
|
While using the fix this morning, I realized the previous code did not account for init_params that are not gibbs sites, so I added an additional check. |
|
Thanks for the fix, @amifalk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug described in #1672 - params updated via gibbs were not initialized when init_params was set