Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kumaraswamy distribution bug fixes #1675

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

e-pet
Copy link
Contributor

@e-pet e-pet commented Nov 9, 2023

Two small fixes as discussed in #1671.

(I was unable to get the tests to run locally - I'm mainly working on windows, which complicates things a bit. Let me know if this is a serious issue, then I'll try to get them to run.)

numpyro/distributions/continuous.py Outdated Show resolved Hide resolved
@fehiepsi
Copy link
Member

Thanks, @e-pet!

@fehiepsi fehiepsi merged commit f5bd186 into pyro-ppl:master Nov 10, 2023
1 check passed
@martinjankowiak
Copy link
Collaborator

looks like this merge may be resulting in some test failures?

FAILED test/test_distributions.py::test_vmap_dist[Kumaraswamy-None-params47] - AttributeError: 'Kumaraswamy' object has no attribute 'base_dist'
FAILED test/test_distributions.py::test_vmap_dist[Kumaraswamy-None-params48] - AttributeError: 'Kumaraswamy' object has no attribute 'base_dist'
FAILED test/test_distributions.py::test_vmap_dist[Kumaraswamy-None-params49] - AttributeError: 'Kumaraswamy' object has no attribute 'base_dist'

@e-pet
Copy link
Contributor Author

e-pet commented Nov 13, 2023

@martinjankowiak Sorry, I am out of my depth for this and will have to refer to @fehiepsi... Happy to do implement / commit any fixes though, if someone can tell me what I have to do.

@martinjankowiak
Copy link
Collaborator

@e-pet no worries this has been dealt with elsewhere !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants