Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change case to render graph for conditioned nodes. #1711

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Change case to render graph for conditioned nodes. #1711

merged 1 commit into from
Dec 30, 2023

Conversation

yayami3
Copy link
Contributor

@yayami3 yayami3 commented Dec 29, 2023

Solves #1710 .
Conditioned nodes were to be isolated so far.
This change makes the graph what it is supposed to be.

fehiepsi
fehiepsi approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yayami3! glad that all tests pass.

@fehiepsi fehiepsi merged commit 9ce2384 into pyro-ppl:master Dec 30, 2023
4 checks passed
@yayami3
Copy link
Contributor Author

yayami3 commented Dec 30, 2023 •
edited

Thanks @fehiepsi
Happy new year!

@yayami3 yayami3 deleted the enhance_render_model branch December 30, 2023 03:09
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
@yayami3 @OlaRonning
change case to render graph (pyro-ppl#1711)
afabd2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yayami3 @fehiepsi