Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove upper bound sphinx #1721

Merged
merged 13 commits into from
Jan 16, 2024
Merged

remove upper bound sphinx #1721

merged 13 commits into from
Jan 16, 2024

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented Jan 15, 2024 •
edited

Trying to fix the error found in #1720

It seems there is a big upgrade in Jan 13 2024.

make -C docs html
make[1]: Entering directory '/home/runner/work/numpyro/numpyro/docs'
Running Sphinx v4.5.0
/opt/hostedtoolcache/Python/3.9.1[8](https://github.com/pyro-ppl/numpyro/actions/runs/7531465780/job/20500091407?pr=1720#step:6:9)/x64/lib/python3.[9](https://github.com/pyro-ppl/numpyro/actions/runs/7531465780/job/20500091407?pr=1720#step:6:10)/site-packages/nbsphinx.py:1450: RuntimeWarning: You are using an unsupported version of pandoc (2.9.2.1).
Your version must be at least (2.14.2) but less than (4.0.0).
Refer to https://pandoc.org/installing.html.
Continuing with doubts...
  nbconvert.utils.pandoc.check_pandoc_version()
loading translations [en]... done

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
make[1]: *** [Makefile:20: html] Error 2
make[1]: Leaving directory '/home/runner/work/numpyro/numpyro/docs'
make: *** [Makefile:26: docs] Error 2
Error: Process completed with exit code 2.

@juanitorduz juanitorduz marked this pull request as draft January 15, 2024 17:00
@juanitorduz juanitorduz marked this pull request as ready for review January 15, 2024 17:26
@juanitorduz juanitorduz changed the title bound version: sphinxcontrib-applehelp<1.0.8 bound version: sphinxcontrib-* Jan 15, 2024
@juanitorduz juanitorduz mentioned this pull request Jan 15, 2024
Merged
@fehiepsi
Copy link
Member

hi @juanitorduz, I think it's better to remove the old restrictions. The old issues might have been resolved in recent versions.

@juanitorduz juanitorduz changed the title bound version: sphinxcontrib-* remove upper bound sphinx Jan 16, 2024
@juanitorduz
Copy link
Contributor Author

Done! I still added a lower bound for Sphinx just to avoid these errors.

fehiepsi
fehiepsi approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @juanitorduz!

@fehiepsi fehiepsi merged commit c2b9e87 into pyro-ppl:master Jan 16, 2024
4 checks passed
@juanitorduz juanitorduz deleted the bound_sphinxcontrib-applehelp_version branch January 16, 2024 16:27
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
@juanitorduz @OlaRonning
remove upper bound sphinx (pyro-ppl#1721)
8ad9ffa 
* bound version

* strong pin

* add pin in setup.py

* missing comma

* fix bound

* fix bound

* add comma

* more bounds

* more bounds

* more bounds

* more bounds

* rm unnecessary bound

* rm pin bounds and unpin sphinx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juanitorduz @fehiepsi