Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix elbo normalization with multi_sample_guide=True #1728

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix elbo normalization with multi_sample_guide=True #1728

merged 1 commit into from
Feb 5, 2024

Conversation

danielward27
Copy link
Contributor

Fixes #1724

fehiepsi
fehiepsi approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danielward27!

@fehiepsi fehiepsi merged commit 977cbc2 into pyro-ppl:master Feb 5, 2024
4 checks passed
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
@danielward27 @OlaRonning
fix elbo normalization with multi_sample_guide=True (pyro-ppl#1728)
d48d5bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect elbo normalisation when multi_sample_guide is True
2 participants
@danielward27 @fehiepsi