Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing nested_sampling.py #1738

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

renecotyfanboy
Copy link
Contributor

I did a small fix for the nested sampling contributed code so that it works with jaxns 2.4.8
It tested it by running the gaussian shell example, which leads to similar results as what we would have expected before

Capture d’écran 2024-02-19 à 13 53 40

@renecotyfanboy
Copy link
Contributor Author

Sorry, I didn't check that there was already an open PR for this task #1727. I added a commit for bumping the jaxns version to the latest, and will close my PR if required

@fehiepsi
Copy link
Member

Thanks, @renecotyfanboy! Could you run make format and make lint to fix the lint issue?

@renecotyfanboy
Copy link
Contributor Author

I manually linted the file with ruff, the make lint and make format tools fails locally due to the header script :

python scripts/update_headers.py
Traceback (most recent call last):
  File "/Users/sdupourque/PycharmProjects/numpyro/scripts/update_headers.py", line 45, in <module>
    while lines[lineno].startswith(comment.format("Copyright")):
IndexError: list index out of range

@fehiepsi
Copy link
Member

Seems like there is a python file which has conflict format in your folder. CI works btw. :)

@fehiepsi fehiepsi merged commit a92bd0d into pyro-ppl:master Feb 21, 2024
4 checks passed
OlaRonning pushed a commit to aleatory-science/numpyro that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants