Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to the docker scripts #1628

Merged
merged 1 commit into from Dec 5, 2018
Merged

Minor updates to the docker scripts #1628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docker/Dockerfile
View file
Open in desktop
Expand Up @@ -35,8 +35,8 @@ USER ${USER_NAME}
RUN curl -o ~/miniconda.sh -O \
https://repo.continuum.io/miniconda/Miniconda${python_version%%.*}-latest-Linux-x86_64.sh && \
bash ~/miniconda.sh -f -b -p ${CONDA_DIR} && \
rm ~/miniconda.sh
ENV CMAKE_PREFIX_PATH="$(dirname $(which conda))/../"
rm ~/miniconda.sh && \
conda install python=${python_version}

# Move to home directory; and copy the install script
WORKDIR ${WORK_DIR}
Expand Down
1 change: 1 addition & 0 deletions docker/install.sh
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ then
if [ ${cuda} = 1 ]; then conda install -y cuda90 -c pytorch; fi
else
conda install -y numpy pyyaml mkl mkl-include setuptools cmake cffi typing
conda install -c mingfeima mkldnn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a requirement to build from source as stated here: https://github.com/pytorch/pytorch.

if [ ${cuda} = 1 ]; then conda install -y cuda90 -c pytorch; fi
git clone --recursive https://github.com/pytorch/pytorch.git
pushd pytorch && git checkout ${pytorch_branch}
Expand Down