module will ignore params with requires_grad=False
#1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
previously approved these changes
Mar 1, 2019
neerajprad
reviewed
Mar 1, 2019
tests/params/test_module.py
Outdated
| def forward(self, s): | ||
| pass | ||
|
|
||
| with warnings.catch_warnings(): |
There was a problem hiding this comment.
nit: I would suggest changing this to with pytest.warns(RuntimeWarning): which will explicitly check that this warning is raised.
| if param_value._cdata != returned_param._cdata: | ||
| target_state_dict[param_name] = returned_param | ||
| else: | ||
| warnings.warn("{} was not registered in the param store because".format(param_name) + |
There was a problem hiding this comment.
nit: space between because and requires_grad in the warning message.
neerajprad
previously approved these changes
Mar 1, 2019
|
The ss-vae example seems to be failing for some reason, but it doesn't seem related. |
neerajprad
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1778