Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply black code formatter #2891

Merged
merged 6 commits into from
Jul 2, 2021
Merged

Apply black code formatter #2891

merged 6 commits into from
Jul 2, 2021

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jul 2, 2021

Resolves #2602

Biting the bullet before 1.7 release 馃槵

Note the only the small commits need to be reviewed; the big "Apply black code formatter" commit is merely applying make format.

eb8680
eb8680 previously approved these changes Jul 2, 2021
Copy link
Member

@eb8680 eb8680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the best time to do this

fehiepsi
fehiepsi previously approved these changes Jul 2, 2021
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to require black>=21.4 because previous versions have different formatting behavior, observed here. See also black release notes for the 21.4b0 release.

@fritzo fritzo dismissed stale reviews from fehiepsi and eb8680 via 378d9db July 2, 2021 04:15
@fehiepsi fehiepsi merged commit b7ba915 into dev Jul 2, 2021
@fritzo fritzo deleted the black branch September 27, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup: use black code formatter
3 participants