Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make tutorial to docs CI workflow #3012

Merged
merged 10 commits into from
Dec 29, 2022
Merged

Add make tutorial to docs CI workflow #3012

merged 10 commits into from
Dec 29, 2022

Conversation

eb8680
Copy link
Member

@eb8680 eb8680 commented Jan 25, 2022

Motivated by off-target Sphinx build errors in #3006. Can't remember if there was a reason we weren't doing this, feel free to close if there was one...

docs/requirements.txt Outdated Show resolved Hide resolved
@eb8680
Copy link
Member Author

eb8680 commented Jan 25, 2022

Not sure what's going on, but the tutorial HTML build is taking forever on the GitHub CI machines. I might have to move this to a separate stage to avoid a big increase in CI turnaround time.

@fritzo
Copy link
Member

fritzo commented Jan 25, 2022

taking forever

that's probably the reason we didn't add this to ci

@eb8680
Copy link
Member Author

eb8680 commented Jan 26, 2022

Still, even on my slow personal laptop make tutorial runs in seconds with no cached builds - there's no way GitHub should be taking 25+ minutes.

@eb8680 eb8680 removed the easy label Jan 26, 2022
pip freeze
- name: Build HTML from tutorials
run: |
SPHINXOPTS="-E" make tutorial
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled the -W Sphinx flag that treats warnings as errors in the CI builds of the tutorial web pages because there are a number of unfixed warnings in dev and they appear unstable across sphinx versions.

@@ -62,6 +62,40 @@ jobs:
run: |
make docs
make doctest
tutorials-html:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the tutorial build to a separate stage to limit the impact on CI time

@eb8680
Copy link
Member Author

eb8680 commented Dec 20, 2022

@fritzo can you take a look at this again? I was helping someone today with issues building the example HTML and this seemed like it would be a useful check to rule out bugs in the tutorials as a cause of build issues versus incorrect versions of Sphinx and related dependencies.

Not sure what's going on, but the tutorial HTML build is taking forever on the GitHub CI machines

This seems to be resolved by not using multiple Sphinx workers (i.e. removing the -j 8 argument from the Sphinx build).

Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this to work @eb8680 !

@fritzo fritzo merged commit e082c09 into dev Dec 29, 2022
@fritzo fritzo deleted the ci-tutorial-html branch January 5, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants