Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom loss documentation #3122

Merged
merged 3 commits into from
Jul 31, 2022

Conversation

e-pet
Copy link
Contributor

@e-pet e-pet commented Jul 30, 2022

As proposed in #3121, these are some minor changes to the custom objectives example page.

  • Renamed from "Custom SVI Objectives" to "Customizing objectives and training loops", also changed the file name.
  • Extended the lower-level pattern to what I hope is a full replacement of svi.step().

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@martinjankowiak
Copy link
Collaborator

@e-pet looks good but can you please make the following changes?

  • add SVI back to the leading heading (Customizing SVI objectives)
  • poutine.trace => pyro.poutine.trace

thanks!

@e-pet
Copy link
Contributor Author

e-pet commented Jul 31, 2022

Done!

@e-pet
Copy link
Contributor Author

e-pet commented Jul 31, 2022

Sorry for the stupid question - is there something I'll need to do from here on?

@martinjankowiak martinjankowiak merged commit bca60c9 into pyro-ppl:dev Jul 31, 2022
@martinjankowiak
Copy link
Collaborator

@e-pet nope just gotta wait for someone on the dev team to merge

OlaRonning pushed a commit to aleatory-science/pyro that referenced this pull request Aug 2, 2022
* Improving custom objectives example

* Rename custom_objectives.ipynb to custom_objectives_training.ipynb

* Minuscule changes as discussed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants