Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compatibility with torch>=1.13 torchvision>=0.14 #3155

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Ensure compatibility with torch>=1.13 torchvision>=0.14 #3155

merged 6 commits into from
Nov 22, 2022

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Nov 21, 2022 •
edited

In preparation for Pyro's upcoming 1.8.3 release, this PR ensures forward compatibility with latest PyTorch release 1.13 but keeps our versions pinned to a conservative torch==1.11.

Fixes include:

  • replace torch.Tensor.lu() with torch.linalg.lu_factor()
  • pin setuptools to avoid distutils drama from numpy.distutils and setuptools (high priority, blocking all other PRs)
  • fix a test to dereference a counter that used to be an int but has become a tensor

@fritzo fritzo added the WIP label Nov 21, 2022
@fritzo fritzo modified the milestones: 1.8.1 release, 1.8.3 Nov 21, 2022
@fritzo fritzo changed the title Bump dependency versions to torch>=1.13 torchvision>=0.14 Ensure compatibility with torch>=1.13 torchvision>=0.14 Nov 22, 2022
@martinjankowiak martinjankowiak merged commit 44267ff into dev Nov 22, 2022
@martinjankowiak martinjankowiak deleted the torch-1.13 branch November 22, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjankowiak martinjankowiak martinjankowiak approved these changes

Assignees
No one assigned
Labels
awaiting review easy high priority
Projects
None yet
Milestone
1.8.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fritzo @martinjankowiak