Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds min_stepsize and max_stepsize to HMC, avoiding infinite loop #3157

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Adds min_stepsize and max_stepsize to HMC, avoiding infinite loop #3157

merged 2 commits into from
Nov 22, 2022

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Nov 22, 2022 •
edited

Fixes #3156

@fritzo fritzo added the bug label Nov 22, 2022
@fritzo fritzo mentioned this pull request Nov 22, 2022
Closed
@fritzo fritzo added this to the 1.8.3 milestone Nov 22, 2022
martinjankowiak
martinjankowiak approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@martinjankowiak martinjankowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@martinjankowiak martinjankowiak merged commit 39a4111 into dev Nov 22, 2022
@martinjankowiak martinjankowiak deleted the fix-3156 branch November 22, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjankowiak martinjankowiak martinjankowiak approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.8.3
Development

Successfully merging this pull request may close these issues.

[Bug] Infinite loop in HMC._find_reasonable_step_size
2 participants
@fritzo @martinjankowiak