Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in log-absolute-derivative of exponential transform (normalizing flow tutorial) closes #3176 #3177

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

felixschltr
Copy link
Contributor

@felixschltr felixschltr commented Feb 2, 2023

This PR addresses Issue #3176

I ran make test and make test-examples locally just to be sure, but since only a single character inside a notebook markdown cell is changed, there shouldn't be bigger problems.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@fritzo fritzo merged commit 8b6d331 into pyro-ppl:dev Feb 2, 2023
@felixschltr
Copy link
Contributor Author

Sorry about the failing lint check. Though I'm kind of surprised by this given the small change. Should I request a revert?

@ordabayevy
Copy link
Member

I think linting is failing because of the new version of the black formatter.

@martinjankowiak
Copy link
Collaborator

yes let's see if #3178 fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants