Bug fix about device of subsample in subsample_messenger.py #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm assuming you're using a plate and using |
|
I have specified the |
Here are some error information: But It works fine when I tried trace the model shape |
|
@hjnnjh can you please provide a minimal runnable script / code snippet that demonstrates this error? |
|
Hi @hjnnjh thanks for the fix! I think it's a little dangerous to decide based on - new_value = value.index_select(dim, self._indices)
+ new_value = value.index_select(dim, self._indices.to(value.device))EDIT looks like the lint errors are due to |
I'm busy building my model the past few days. I'll provide a minimal runnable script soon. |
Thanks for your reply! I think this is a better solution. It works fine now. |
…bsample_messenger.py
|
@hjnnjh looks good. Can you just try running |
I just reformatted |
|
@fritzo Hello, can this PR be merged? |
fehiepsi
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the following changes on my device. Currently works fine. Since the whole Pyro project is very complex, I am not sure where the source of the bug is. I hope you can fix this bug soon.