Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jit ELBO sign error #3229

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Fix jit ELBO sign error #3229

merged 3 commits into from
Jun 21, 2023

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jun 21, 2023

Fixes #2798
Closes #2799

This fixes a sign error in JitTraceGraph_ELBO and adds a regression test for other ELBOs.

Tested

  • added a regression test with a golden value ELBO computed via Trace_ELBO with 1e8 particles.

Comment on lines +46 to +48
_t: torch.Tensor
_provenance: frozenset

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix for mypy

Copy link
Collaborator

@martinjankowiak martinjankowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. looks like we chose some poor names for some of these functions...

@fritzo
Copy link
Member Author

fritzo commented Jun 21, 2023

@martinjankowiak Thanks for reviewing. Merge?

@martinjankowiak martinjankowiak merged commit e20a65c into dev Jun 21, 2023
9 checks passed
@martinjankowiak martinjankowiak deleted the fix-jit-sign-error branch June 21, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Sign error in JitTraceGraph_ELBO
2 participants