Replace flake8+isort with ruff #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjankowiak
approved these changes
Jun 22, 2023
|
@fehiepsi you might consider using ruff for numpyro also. ruff has many checks beyond flake8+isort, and it is easy to incrementally opt-in to those checks. |
|
thanks @fritzo. I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3230
This PR replaces Pyro's use of
flake8andisortwithruff, speeding up this phase of linting by about 200x.Before this PR
After this PR
I've enabled only the most basic of ruff checks: E, F, and I.