Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWA implementation #3249

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

SWA implementation #3249

wants to merge 1 commit into from

Conversation

yuanqing-wang
Copy link

No description provided.

@yuanqing-wang
Copy link
Author

Addresses https://forum.pyro.ai/t/using-stochastic-weight-averaging-swa-in-pyro/5290/2

@fritzo
Copy link
Member

fritzo commented Jul 25, 2023 •
edited

Hi @yuanqing-wang, I'd recommend taking a look at our CONTRIBUTING.md, and in particular:

  • make format and make lint to work past linting errors
  • add torchcontrib to the EXTRAS_REQUIRE list in setup.py (and ideally lower bound a version so we know SWA is available)
  • add a test, probably in a new file tests/optim/test_swa.py
  • probably add a pytest.importorskip("torchcontrib") to your test
  • add a new automodule section to docs/source/pyro.optim.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting response enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuanqing-wang @fritzo @eb8680