Use `functools.wraps` to preserve `handler` signature #3287

ordabayevy · 2023-10-24T17:51:25Z

#3285 didn't fix the issue of the _make_handler function not preserving the signature of the handler. This PR fixes it by using functools.wraps as explained here.

+ small typo fix

Confirmed it by locally building the docs:

use functools.wraps to preserve handler signature

b1ff9e1

ordabayevy added usability awaiting review labels Oct 24, 2023

lits -> list

779bf9e

ordabayevy added the easy label Oct 24, 2023

ordabayevy requested a review from fritzo October 24, 2023 18:10

fritzo approved these changes Oct 24, 2023

View reviewed changes

fritzo merged commit 23e6470 into dev Oct 24, 2023
9 checks passed

ordabayevy deleted the preserve-handler-signature branch October 24, 2023 19:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `functools.wraps` to preserve `handler` signature #3287

Use `functools.wraps` to preserve `handler` signature #3287

ordabayevy commented Oct 24, 2023 •

edited

Use functools.wraps to preserve handler signature #3287

Use functools.wraps to preserve handler signature #3287

Conversation

ordabayevy commented Oct 24, 2023 • edited

Use `functools.wraps` to preserve `handler` signature #3287

Use `functools.wraps` to preserve `handler` signature #3287

ordabayevy commented Oct 24, 2023 •

edited