Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type annotate messengers #3308

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Type annotate messengers #3308

merged 2 commits into from
Dec 24, 2023

Conversation

ordabayevy
Copy link
Member

  • scale_messenger
  • seed_messenger
  • subsample_messenger
  • substitute_messenger

fritzo
fritzo approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see type hints here!

@fritzo fritzo merged commit 5d920aa into dev Dec 24, 2023
9 checks passed
@ordabayevy ordabayevy deleted the type-poutines branch December 24, 2023 19:18
@ordabayevy ordabayevy mentioned this pull request Feb 5, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ordabayevy @fritzo