Fix bug in CVAE example #3325
Merged
Fix bug in CVAE example #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
requested changes
Feb 10, 2024
Comment on lines
-126
to
-129
| pytest.param( | ||
| "cvae/main.py --num-quadrant-inputs=1 --num-epochs=1", | ||
| marks=pytest.mark.skip(reason="https://github.com/pyro-ppl/pyro/issues/3273"), | ||
| ), |
There was a problem hiding this comment.
Could you replace these four lines with just the string
"cvae/main.py --num-quadrant-inputs=1 --num-epochs=1",
The pytest.mark.skip is just to skip the test, and we now want it to run.
There was a problem hiding this comment.
Added the line for the test.
examples/cvae/baseline.py
Outdated
| loss = F.binary_cross_entropy(input, target, reduction="none") | ||
| loss[target == self.masked_with] = 0 | ||
| # only calculate loss on target pixels (value = -1) | ||
| loss = F.binary_cross_entropy(input[target != self.masked_with], target[target != self.masked_with], reduction='none') |
There was a problem hiding this comment.
Could you run make lint to fix the lint error? I think it's just a line too long.
There was a problem hiding this comment.
Had checked the format using make lint and fix the lint error.
The bug is caused by input validation (only accept value between 0 or 1 otherwise raise error) of F.binary_cross_entropy_loss after Pytorch 2.1 update. The fix is to manually mask the input of the loss function to avoid invalid value rather than removing the loss of invalid input from the final loss result. Please refer to:pyro-ppl#3273 for the initial report of the bug
fritzo
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3273
The bug is caused by input validation (only accept value between 0 or 1 otherwise raise error) of F.binary_cross_entropy_loss after Pytorch 2.1 update. The fix is to manually mask the input of the loss function to avoid invalid value rather than removing the loss of invalid input from the final loss result. Please refer to:#3273 for the initial report of the bug