Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC-8 CI error test #3349

Merged
merged 3 commits into from
Mar 27, 2024
Merged

GCC-8 CI error test #3349

merged 3 commits into from
Mar 27, 2024

Conversation

ordabayevy
Copy link
Member

No description provided.

@ordabayevy
Copy link
Member Author

Error message from CI:

/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/torch/include/c10/util/C++17.h:16:2: error: #error "You're trying to build PyTorch with a too old version of GCC. We need GCC 9 or later."

@fritzo
Copy link
Member

fritzo commented Mar 27, 2024

I guess we'll need to bump gcc version here?

@ordabayevy
Copy link
Member Author

Do we need to upgrade g++ as well @fritzo ?

@ordabayevy ordabayevy requested a review from fritzo March 27, 2024 22:30
@ordabayevy ordabayevy merged commit 0e08427 into dev Mar 27, 2024
9 checks passed
@ordabayevy ordabayevy deleted the gcc-9 branch March 27, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzo fritzo fritzo approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ordabayevy @fritzo