Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split LambdaPoutine into ScalePoutine + IndepPoutine #530

Merged
merged 2 commits into from
Nov 8, 2017

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Nov 8, 2017

This is a pure refactoring PR.

Why?

This will make it easy to scale different parts of a dataset, e.g. in stratified sampling for fraud detection.

Copy link
Collaborator

@martinjankowiak martinjankowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if tests pass. while we're at it we should probably get rid of "map_data_stack" everywhere

@fritzo
Copy link
Member Author

fritzo commented Nov 8, 2017

@martinjankowiak Mind if I do the map_data_stack cleanup in a separate PR? I'd like to rename it to cond_indep_stack and reverse it (to be more pythonic).

@martinjankowiak
Copy link
Collaborator

@fritzo i suppose that's ok... seems awfully indulgent with our limited travis cores though ; )

@fritzo
Copy link
Member Author

fritzo commented Nov 8, 2017

Ready to merge.

@martinjankowiak martinjankowiak merged commit a8c39d3 into dev Nov 8, 2017
@martinjankowiak martinjankowiak deleted the split-lambda-poutine branch November 8, 2017 04:15
@fritzo
Copy link
Member Author

fritzo commented Nov 8, 2017

Thanks, Martin!

@fritzo fritzo mentioned this pull request Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants