-
-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify documentation of iarange #545
Conversation
@srush Thanks for pointing this out. Do these changes help? |
Yup, very clear! Although of course a
Seems more safe to me... |
Ready to merge (tests timed out). |
theres one snag with deploying this which is that the docs track master, which means that other docs changes eg splitting LambdaPoutine into ScalePoutine + IndepPoutine will also be deployed and will be inconsistent with the release code. i suggest we wait until the next minor version/patch to deploy |
Good point. Now is probably a good time to release a patch that includes the fix #533. |
@neerajprad let's address this test timeout issue we're facing before we release a patch, so I won't have to click RESTART RESTART RESTART when we push to master 😄 |
Ok, I suggest we cut a patch release this morning. Then @null-a can later update AIR in |
Fixes #542
This aims to clarify the purpose of
iarange
. The docs are getting a little long, so I may trim them back down when we have a dedicated tutorial. I haven't addressed context managers since that's a basic python concept outside of Pyro.