New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrupted code when editing content of 404 page. #1752
Comments
What browser are you using? Have you tested with any others? Also is the WYSIWYG configuration modified or still using the default? |
Sorry - Should have included browsers: |
Could you pastie in the entire input? Also, what is the history of this install? Upgraded from previous versions? Installed directly? What are the steps required to make this appear as broken? |
Thanks Phil. I have seen this in 2.1.2pro locally installed client sites and a 2.1.3pro locally installed dev site but worked around it. However I thought I should flag it when I noticed the same behaviour in 2.2.dev (pro) which I grabbed on 10-AUG and installed on 11-AUG. So, another way to see this is to simply change from HTML to either WYSIWYG mode, make some change to the wording - without touching the link, save the edit, test the 404 page and see that the link is not working. Return to the 404 Page in the editor and check the HTML. The issue here is that if a site is put into production by someone, and a client is then given the task to add his/her own wording, the link will be broken. Thats how I discovered this issue in the first place. Just though that it should be flagged and looked into as others may fall into this trap. |
Thank you for the run through, that was REALLY helpful! So I have recreated the bug: http://d.pr/i/IFTV I think this is down the regex being used by CKEditor to switch its HTML around - and technically the code we have there is invalid. It should be:
or
I guess I'll just make the change to the 1st, to keep the HTML consistent. |
Phil - Thanks for the fix. Pleased that I was able to help with the added details. |
Pyro2.2dev and 2.1.3 (I have not tested 2.1.4dev or gone earlier that 2.1.3)
If the content in the 404 page is edited in CKeditor, the link code gets mangled like so:
href="{{ pages:url id=" title="Home">here
Opening and closing [a] tags omitted for clarity.
The text was updated successfully, but these errors were encountered: