Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3/fix doctrine dependency #2890

Merged
merged 3 commits into from Aug 3, 2013
Merged

2.3/fix doctrine dependency #2890

merged 3 commits into from Aug 3, 2013

Conversation

brignoni
Copy link
Contributor

This resolves the following issues.

Missing require

Fix “unknown database type enum requested"

…SqlSchemaManager but it was not specified as a require in the Illuminate composer.json. So we need to add it here.
	* Should probably be addressed in Doctrine, if not in Illuminate\Capsule
	* Doctrine 2: Resolving “unknown database type enum requested” - http://wildlyinaccurate.com/doctrine-2-resolving-unknown-database-type-enum-requested
	* Unknown enum database type in migration file / Doctrine issue - laravel/framework#1346
	* Error when mapping database enum field type - symfony/symfony#866
@brignoni
Copy link
Contributor Author

brignoni commented Aug 2, 2013

Closing. I am going to submit this to the illuminate/database repo.

@brignoni brignoni closed this Aug 2, 2013
@brignoni brignoni reopened this Aug 3, 2013
@brignoni
Copy link
Contributor Author

brignoni commented Aug 3, 2013

Reopening because the guys at Laravel won't accept it as a direct dependency of illuminate database. They explained its a suggested dependency. So we do need to add the require to PyroCMS.

This is the attempted PR on laravel/framework
laravel/framework#2020
This is a related issue that explain why the don't accept certain direct dependencies.
laravel/framework#1886

@brignoni
Copy link
Contributor Author

brignoni commented Aug 3, 2013

That was quick! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants