-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching past fires via the API #109
Comments
Hey there 👋 I agree that this should be added in the database, but then there are a few things to decide:
Tagging a few extra people @jeanpasquier75 @florianriche @martin1tab @chloeskt, any thoughts? |
I am not sure I have fully understood your question but we have indeed built the So, to add it in the database, I guess that there are two options: either directly adding the data that is encapsulated in the
For sure, it will ultimately be related to this discussion, especially if alerts raised by our devices and acknowledged by firemen are supposed to enter the database and are displayed as "past fires" on the map after a given time period. But leaving aside this mechanism, the |
Oh alright, I thought it was a mock fire history. Regarding the database, we have to think about the long-term production case. So we need an updated (or several) source of wildfire with accurate location that we can fetch. If there is an API to request that would be good news! For the scope, let's restrict this for now to admin, which will be the scope granted to the backend of the platform. Otherwise we won't get things moving forward soon 😅 |
From my understanding, we want to store the fire history within our database. This implies to create new routes to the API querying this table, at least:
Am I correct ? 😄 The csv would be loaded to the db using the API client, is that what you meant @frgfm ? The question is who is allowed to By "the scope of your request" @frgfm did you refer to any filter on |
@jeanpasquier75 yes about the methods Regarding how we fill the DB, the API client could be a good way indeed Exactly about the scope of the request |
Alright, time to close this issue! I'll open a PR by the end of the weekend 👌 |
@pechouc the feature was just deployed and made available through the client 👌 |
Hello everyone,
Here is a non-urgent issue related to this one in the Pyro-Platform repository!
In order to display past fires on the map, we are currently reading a local file stored within the repository. The goal would be to remove it and instead fetch this information via the Pyro-API. If I understood well, for now, there is no table dedicated to past fires (which could be useful not only for the platform but also for the data science team typically) and this issue is designed to discuss its addition to the database.
To be more precise about the
historic_fires.csv
file, it was built out of a raw dataset of satellite fire detections which we preprocessed, notably in this Colab. We added several fields like the department and the "commune" where the fire occurred (as well as the population, area and density of the locality).We wanted to use the latter to compute the density of population in the area, so as to approximately filter urban fires out of the dataset. However, we have not yet implemented this filtering on the platform and for now,
department
is the only added field which is really required. I mention this in case we are limited for the number of fields.Last remark: at some point, I guess we might want to add fires detected by our own devices and acknowledged by firemen to the past fires table in the database.
All that being said, here are my question(s):
historic_fires.csv
file as is to the database?Thanks a lot for your help, I hope that everything is clear!
The text was updated successfully, but these errors were encountered: