-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Content] Large content files should be removed from repo #35
Comments
Hello @frgfm! Sorry for answering this issue so late, we have indeed added to our to-do list the removal of local data files from the repository. These are:
|
No worries, we all had our hands busy!
|
Thanks for your answer 🙏 I have made a quick test in a notebook to check whether we can fetch the As for |
Cool for the geojson! Yes, I just checked there is no available method in the API client so far (but I doubt we'll need to implement a route in the API itself) |
NB: I opened this issue in the Pyro-API repository to discuss the addition of historic fires to the database 🙂 |
We discussed where it could be stored, but I might have a better question @pyronear/front-end : what is the feature related to historic past wildfires? Do we really need it? This is a monitoring platform so I don't see the value of displaying static information. If we are to display past events happening in their region, we need to fetch it through the API. But I'm starting to wonder whether these historic fires shouldn't be removed, what do you think? |
Simply put, graphics assets could indeed be stored in the git history as they have a very limited size (event though we could avoid it). However, content files like the French geojson or wildfire history data should be moved to release attachments or on cloud storage to preserve git history sanity.
They could be downloaded when the app starts and cached.
The text was updated successfully, but these errors were encountered: