Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Extend API client features for platform demo #61

Closed
5 tasks
frgfm opened this issue Nov 23, 2020 · 4 comments · Fixed by #62
Closed
5 tasks

[client] Extend API client features for platform demo #61

frgfm opened this issue Nov 23, 2020 · 4 comments · Fixed by #62
Assignees
Labels
Milestone

Comments

@frgfm
Copy link
Member

frgfm commented Nov 23, 2020

Following up on pyronear/pyro-platform#19, the following features need to be added to the client:

Considering the scopes of several routes are going to change (more restricted) with #45, this is all the more important since, if they are able to use GET on some routes without authentication, this might not be true in the future!

@Akilditu
Copy link

Thanks for this issue @frgfm !

Adding to the needs the ability to access the medias (frames) that triggered the alerts as we will display them in the platform (let's say at least on frame per alert for 1.0)

@florianriche
Copy link
Contributor

I am starting a PR to add the functions to the Client; stop me if somebody already started working on it !

@florianriche florianriche self-assigned this Nov 24, 2020
@florianriche
Copy link
Contributor

For the last point, shall the API returns a real media or just the bucket_key to retrieve the image (from Carnot computing buckets)?

To me, it seems it would be a big load to put on the API to retrieve the images.

Or are we saying it is the API Client's job to retrieve those medias? In that case it's fine by me.

@Akilditu
Copy link

Akilditu commented Nov 24, 2020

For the last point, shall the API returns a real media or just the bucket_key to retrieve the image (from Carnot computing buckets)?

To me, it seems it would be a big load to put on the API to retrieve the images.

Or are we saying it is the API Client's job to retrieve those medias? In that case it's fine by me.

That's a good point.

Maybe easier for demo that API handles this

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants