Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding historic fires #24

Closed
wants to merge 4 commits into from
Closed

adding historic fires #24

wants to merge 4 commits into from

Conversation

abdi-adel
Copy link
Collaborator

Aim of the Pull Request :

Adding the historic fires on both 'alerts' and 'risks' map.

More detailed info:

Adding made :

Adding a new dataset "historic_fires.csv" in 'data' folder
Adding a new callback in 'Callbacks related to the "Niveau de Risque" page' in main.py
Adding a new callback in 'Callbacks related to the "Alertes et Infrastructures" dashboard' in main.py

Adding two functions in utils.py : get_old_fire_positions* and build_historic_markers functions
*in this first function, we also customised the markers of the historic fires to improve the visualization on the map

Adding some imports in utils.py

Adding a new button* in the homepage.py:
*the new button allows to visualize or not the historic fires on the map

Changing made:
Editing the build_risks_map() function by adding the build_historic_markers in risks.py
Editing the build_alerts_map() function by adding the build_historic_markers in alerts.py

historic_fires_alert_on

historic_fires_alert_on_date

historic_fires_alert_off

historic_fires_alert_on_popup_schematique

historic_fires_alert_on_popup

Note 1 : No density filter

Thanks for reviewing

@pechouc pechouc added the type: enhancement New feature or request label Dec 4, 2020
@pechouc
Copy link
Collaborator

pechouc commented Dec 4, 2020

Oops, I think I messed up while trying to make Flake8 styling modifications locally. I wanted to push my modifications on the remote historic_fires branch but the wrong local branch was pushed... I am looking for the simplest fix we could use.

EDIT: Just to keep this post up to date, after discussing the issue with Adel on Slack, we are going to make a new Pull Request and a new, clean remote branch tonight.

Copy link
Contributor

@nrslt nrslt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR guys, honestly not much to add, seems to work smoothly!

btw thanks for adopting the dead tree icon, I am well aware that it will be replaced at some point but it's nice to see it here :)

@pechouc
Copy link
Collaborator

pechouc commented Dec 4, 2020

The new PR ready for review is here: #25!

@Akilditu
Copy link
Collaborator

Akilditu commented Dec 5, 2020

The new PR ready for review is here: #25!

Shall we close this one ?

@pechouc
Copy link
Collaborator

pechouc commented Dec 5, 2020

Shall we close this one ?

Yes, I just wanted to wait a bit before closing it, so that comments having disappeared from one PR to the other would not be surprising but we do not need it anymore.

@pechouc pechouc closed this Dec 5, 2020
@pechouc pechouc deleted the historic_fires branch December 5, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants