-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markers customization #28
Conversation
getting up to date with original repo
feat: Set up dockerized server for the dash app (#3)
…jects to be used in the homepage.py file ; changed the layout of the homepage in order to better fit our needs
feat: Sets the project for automatic deployment on Heroku (#5)
graphs.py new file + some changes in homepage.py layout ! (#7)
Added the slider and the callback for interactivity (#8)
getting latest commits and PRs
getting latest changes
feat : Added new markers types and live alerts features (pyronear#23)
Indeed this would be a good idea to host those icons somewhere else that in assets folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR !
Could you please resolve the 2 following flake8 errors :
./app/alerts.py:114:55: E261 at least two spaces before inline comment
./app/alerts.py:155:56: E261 at least two spaces before inline comment
@Akilditu yup, I think that would be the best thing to do 👌 |
@nrslt if the reason the PR was closed is only about updating the branch, you can merge master (or another branch for that matter) ;) |
Hi guys,
I just wanted to quickly add the new markers to this existing PR.
at this point it looks like this:
![Screenshot 2020-12-09 at 12 20 51](https://user-images.githubusercontent.com/64283717/101628360-fbede080-3a1f-11eb-8e9f-333f8fef93ff.png)
To improve these, we will need to: