Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update training script #101

Merged
merged 7 commits into from
Feb 11, 2021

Conversation

MateoLostanlen
Copy link
Member

The purpose of this PR is to update the training script and to propose a collab training to make it accessible to everyone.

Please let me now in this PR if you have comment on the collab too : (https://colab.research.google.com/gist/MateoLostanlen/1300692a2ab41418276b455f4eeab64c/train-wildfire.ipynb)

@MateoLostanlen MateoLostanlen added the type: enhancement New feature or request label Feb 10, 2021
@MateoLostanlen MateoLostanlen self-assigned this Feb 10, 2021
@MateoLostanlen MateoLostanlen added this to In progress in PyroNear kanban via automation Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #101 (c9598d6) into master (8366787) will increase coverage by 0.16%.
The diff coverage is 96.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   91.75%   91.92%   +0.16%     
==========================================
  Files          16       17       +1     
  Lines         631      656      +25     
==========================================
+ Hits          579      603      +24     
- Misses         52       53       +1     
Flag Coverage Δ
unittests 91.92% <96.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyrovision/models/rexnet.py 95.83% <95.83%> (ø)
pyrovision/models/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8366787...657f54a. Read the comment docs.

@frgfm frgfm added the ext: references Related to references label Feb 10, 2021
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left a few comments, let me know what you think

references/classification/WildFire/torch/train.py Outdated Show resolved Hide resolved
references/classification/WildFire/torch/train.py Outdated Show resolved Hide resolved
references/classification/WildFire/torch/README.md Outdated Show resolved Hide resolved
references/classification/WildFire/torch/README.md Outdated Show resolved Hide resolved
@MateoLostanlen
Copy link
Member Author

Done :)

PyroNear kanban automation moved this from In progress to Reviewer approved Feb 11, 2021
Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Also I'm wondering, but here we modified the training script for Wildfire. If this is gonna remain our video dataset, we need to find another name to specify that it's image classification 🤷‍♂️

@MateoLostanlen MateoLostanlen merged commit 9bfc6f6 into pyronear:master Feb 11, 2021
PyroNear kanban automation moved this from Reviewer approved to Done Feb 11, 2021
@MateoLostanlen MateoLostanlen deleted the updateTrainingScript branch June 7, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references type: enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants