Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replaced Flatten by torch version #102

Merged
merged 1 commit into from
Feb 11, 2021
Merged

refactor: Replaced Flatten by torch version #102

merged 1 commit into from
Feb 11, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Feb 10, 2021

This PR simply replaces the in-house Flatten module implementation by torch one, now that one has been added to the framework.

@frgfm frgfm added type: enhancement New feature or request module: models Related to models labels Feb 10, 2021
@frgfm frgfm added this to the 0.1.1 milestone Feb 10, 2021
@frgfm frgfm self-assigned this Feb 10, 2021
MateoLostanlen
MateoLostanlen approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frgfm frgfm merged commit bad74ad into master Feb 11, 2021
@frgfm frgfm deleted the flatten-removed branch February 11, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateoLostanlen MateoLostanlen MateoLostanlen approved these changes

Assignees

@frgfm frgfm

Labels
module: models Related to models type: enhancement New feature or request
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frgfm @MateoLostanlen