Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Dockerfile for ubuntu image #108

Merged
merged 4 commits into from
Feb 28, 2021
Merged

feat: Added Dockerfile for ubuntu image #108

merged 4 commits into from
Feb 28, 2021

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Feb 17, 2021

This PR introduces the following modifications:

  • adds a Dockerfile for a basic ubuntu image
  • updated README
  • added CI job to check that the docker builds successfully

Any feedback is welcome!

@frgfm frgfm added this to the 0.1.1 milestone Feb 17, 2021
@frgfm frgfm self-assigned this Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #108 (bf08400) into master (a759151) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.01%     
==========================================
  Files          17       18       +1     
  Lines         651      652       +1     
==========================================
+ Hits          601      602       +1     
  Misses         50       50              
Flag Coverage Δ
unittests 92.33% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyrovision/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a759151...a6683ad. Read the comment docs.

Dockerfile Show resolved Hide resolved
chloeskt
chloeskt previously approved these changes Feb 17, 2021

Access all pyrovision datasets just like any `torchvision.datasets.VisionDataset`:
You can use the library like any other python package to analyze your documents as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you removed this here ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was starting to think that this is the purpose of the documentation, not the README. Usage instructions should be plain user-friendly examples of how to use the package in my opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ok

@MateoLostanlen
Copy link
Member

All good :)

@frgfm frgfm modified the milestones: 0.1.1, 0.1.2 Feb 28, 2021
@frgfm frgfm merged commit 217d461 into master Feb 28, 2021
@frgfm frgfm deleted the docker branch February 28, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants